rename nullable to optional #937#960
Merged
dOrgJelli merged 1 commit intoprealpha-devfrom Jun 27, 2022
Merged
Conversation
fetsorn
requested review from
Niraj-Kamdar,
dOrgJelli,
krisbitney,
namesty and
nerfZael
as code owners
dOrgJelli
approved these changes
Jun 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Values that are not guaranteed to exist can be called Nullable, if empty values equal null, or Optional, if empty values still encapsulate the original data type.
At first assemblyscript msgpack implementation used nullable and the Nullable container. Then rust msgpack kept the same naming convention, even though it used Option types. Now that assemblyscript also uses Option types, the naming should be changed.